diff --git a/src/main/scala/gitbucket/core/controller/ReleasesController.scala b/src/main/scala/gitbucket/core/controller/ReleasesController.scala index 90c887c..89de469 100644 --- a/src/main/scala/gitbucket/core/controller/ReleasesController.scala +++ b/src/main/scala/gitbucket/core/controller/ReleasesController.scala @@ -8,9 +8,9 @@ import gitbucket.core.util.Implicits._ import org.scalatra.forms._ import gitbucket.core.releases.html -import gitbucket.core.util.SyntaxSugars.using import org.apache.commons.io.FileUtils import org.eclipse.jgit.api.Git +import scala.util.Using class ReleaseController extends ReleaseControllerBase @@ -130,7 +130,7 @@ val Seq(previousTag, currentTag) = multiParams("splat") val previousTagId = repository.tags.collectFirst { case x if x.name == previousTag => x.id }.getOrElse("") - val commitLog = using(Git.open(getRepositoryDir(repository.owner, repository.name))) { git => + val commitLog = Using.resource(Git.open(getRepositoryDir(repository.owner, repository.name))) { git => val commits = JGitUtil.getCommitLog(git, previousTagId, currentTag).reverse commits .map { commit => diff --git a/src/main/scala/gitbucket/core/controller/RepositoryViewerController.scala b/src/main/scala/gitbucket/core/controller/RepositoryViewerController.scala index 678c36f..a0db8bd 100644 --- a/src/main/scala/gitbucket/core/controller/RepositoryViewerController.scala +++ b/src/main/scala/gitbucket/core/controller/RepositoryViewerController.scala @@ -996,7 +996,7 @@ val mode = treeWalk.getFileMode.getBits JGitUtil.openFile(git, repository, commit.getTree, treeWalk.getPathString) { in => val tempFile = File.createTempFile("gitbucket", ".archive") - val size = using(new FileOutputStream(tempFile)) { out => + val size = Using.resource(new FileOutputStream(tempFile)) { out => IOUtils.copy( EolStreamTypeUtil.wrapInputStream( in, @@ -1013,7 +1013,7 @@ val entry: ArchiveEntry = entryCreator(entryPath, size, date, mode) archive.putArchiveEntry(entry) - using(new FileInputStream(tempFile)) { in => + Using.resource(new FileInputStream(tempFile)) { in => IOUtils.copy(in, archive) } archive.closeArchiveEntry() diff --git a/src/main/scala/gitbucket/core/controller/api/ApiPullRequestControllerBase.scala b/src/main/scala/gitbucket/core/controller/api/ApiPullRequestControllerBase.scala index 63996a1..3a827ab 100644 --- a/src/main/scala/gitbucket/core/controller/api/ApiPullRequestControllerBase.scala +++ b/src/main/scala/gitbucket/core/controller/api/ApiPullRequestControllerBase.scala @@ -8,10 +8,10 @@ import gitbucket.core.util.Directory.getRepositoryDir import gitbucket.core.util.Implicits._ import gitbucket.core.util.JGitUtil.CommitInfo -import gitbucket.core.util.SyntaxSugars.using import gitbucket.core.util._ import org.eclipse.jgit.api.Git import org.scalatra.NoContent +import scala.util.Using import scala.jdk.CollectionConverters._ @@ -173,7 +173,7 @@ issueId => getPullRequest(owner, name, issueId) map { case (issue, pullreq) => - using(Git.open(getRepositoryDir(owner, name))) { git => + Using.resource(Git.open(getRepositoryDir(owner, name))) { git => val oldId = git.getRepository.resolve(pullreq.commitIdFrom) val newId = git.getRepository.resolve(pullreq.commitIdTo) val repoFullName = RepositoryName(repository) diff --git a/src/main/scala/gitbucket/core/controller/api/ApiRepositoryContentsControllerBase.scala b/src/main/scala/gitbucket/core/controller/api/ApiRepositoryContentsControllerBase.scala index 07cd144..edcefc4 100644 --- a/src/main/scala/gitbucket/core/controller/api/ApiRepositoryContentsControllerBase.scala +++ b/src/main/scala/gitbucket/core/controller/api/ApiRepositoryContentsControllerBase.scala @@ -5,10 +5,10 @@ import gitbucket.core.util.Directory.getRepositoryDir import gitbucket.core.util.JGitUtil.{FileInfo, getContentFromId, getFileList} import gitbucket.core.util._ -import gitbucket.core.util.SyntaxSugars.using import gitbucket.core.view.helpers.{isRenderable, renderMarkup} import gitbucket.core.util.Implicits._ import org.eclipse.jgit.api.Git +import scala.util.Using trait ApiRepositoryContentsControllerBase extends ControllerBase { self: ReferrerAuthenticator with WritableUsersAuthenticator with RepositoryCommitFileService => @@ -45,7 +45,7 @@ getFileList(git, revision, dirName).find(f => f.name.equals(fileName)) } - using(Git.open(getRepositoryDir(params("owner"), params("repository")))) { git => + Using.resource(Git.open(getRepositoryDir(params("owner"), params("repository")))) { git => val fileList = getFileList(git, refStr, path) if (fileList.isEmpty) { // file or NotFound getFileInfo(git, refStr, path) @@ -113,7 +113,7 @@ data <- extractFromJsonBody[CreateAFile] } yield { val branch = data.branch.getOrElse(repository.repository.defaultBranch) - val commit = using(Git.open(getRepositoryDir(repository.owner, repository.name))) { git => + val commit = Using.resource(Git.open(getRepositoryDir(repository.owner, repository.name))) { git => val revCommit = JGitUtil.getRevCommitFromId(git, git.getRepository.resolve(branch)) revCommit.name } diff --git a/src/main/scala/gitbucket/core/service/RepositoryCreationService.scala b/src/main/scala/gitbucket/core/service/RepositoryCreationService.scala index 8e7a662..c72e85b 100644 --- a/src/main/scala/gitbucket/core/service/RepositoryCreationService.scala +++ b/src/main/scala/gitbucket/core/service/RepositoryCreationService.scala @@ -4,7 +4,6 @@ import java.util.concurrent.ConcurrentHashMap import gitbucket.core.model.Profile.profile.blockingApi._ -import gitbucket.core.util.SyntaxSugars._ import gitbucket.core.util.Directory._ import gitbucket.core.util.{FileUtil, JGitUtil, LockUtil} import gitbucket.core.model.{Account, Role} @@ -18,6 +17,7 @@ import scala.concurrent.ExecutionContext.Implicits.global import scala.concurrent.Future +import scala.util.Using object RepositoryCreationService { @@ -107,7 +107,7 @@ JGitUtil.initRepository(gitdir) if (initOption == "README" || initOption == "EMPTY_COMMIT") { - using(Git.open(gitdir)) { git => + Using.resource(Git.open(gitdir)) { git => val builder = DirCache.newInCore.builder() val inserter = git.getRepository.newObjectInserter() val headId = git.getRepository.resolve(Constants.HEAD + "^{commit}") @@ -148,7 +148,7 @@ copyRepositoryDir.foreach { dir => try { - using(Git.open(dir)) { git => + Using.resource(Git.open(dir)) { git => git.push().setRemote(gitdir.toURI.toString).setPushAll().setPushTags().call() } } finally {