diff --git a/src/main/scala/view/AvatarImageProvider.scala b/src/main/scala/view/AvatarImageProvider.scala index 54fc9c2..fda49c0 100644 --- a/src/main/scala/view/AvatarImageProvider.scala +++ b/src/main/scala/view/AvatarImageProvider.scala @@ -33,7 +33,7 @@ s"""${context.path}/${account.userName}/_avatar""" } } getOrElse { - if(mailAddress.nonEmpty && getSystemSettings().gravatar){ + if(getSystemSettings().gravatar){ s"""http://www.gravatar.com/avatar/${StringUtil.md5(mailAddress.toLowerCase)}?s=${size}""" } else { s"""${context.path}/_unknown/_avatar""" diff --git a/src/test/scala/view/AvatarImageProviderSpec.scala b/src/test/scala/view/AvatarImageProviderSpec.scala index 6d017de..b839512 100644 --- a/src/test/scala/view/AvatarImageProviderSpec.scala +++ b/src/test/scala/view/AvatarImageProviderSpec.scala @@ -41,32 +41,32 @@ "" } - "show local image for unknown user if gravatar integration is enabled" in { + "show unknown image for unknown user if gravatar integration is enabled" in { val provider = new AvatarImageProviderImpl(None, createSystemSettings(true)) provider.toHtml("user", 20).toString mustEqual - "" + "" } - "show local image for specified mail address if gravatar integration is disabled" in { + "show unknown image for specified mail address if gravatar integration is disabled" in { val provider = new AvatarImageProviderImpl(None, createSystemSettings(false)) provider.toHtml("user", 20, "hoge@hoge.com").toString mustEqual - "" + "" } "add tooltip if it's enabled" in { val provider = new AvatarImageProviderImpl(None, createSystemSettings(false)) provider.toHtml("user", 20, "hoge@hoge.com", true).toString mustEqual - "" + "" } } private def createAccount(image: Option[String]) = Account( - userName = "", - fullName = "", + userName = "user", + fullName = "user@localhost", mailAddress = "", password = "", isAdmin = false, @@ -95,6 +95,7 @@ def toHtml(userName: String, size: Int, mailAddress: String = "", tooltip: Boolean = false) (implicit context: app.Context): Html = getAvatarImageHtml(userName, size, mailAddress, tooltip) + override def getAccountByMailAddress(mailAddress: String)(implicit context: app.Context): Option[Account] = account override def getAccountByUserName(userName: String)(implicit context: app.Context): Option[Account] = account override def getSystemSettings()(implicit context: app.Context): SystemSettings = settings }