diff --git a/src/main/scala/app/SystemSettingsController.scala b/src/main/scala/app/SystemSettingsController.scala index c952712..68efda5 100644 --- a/src/main/scala/app/SystemSettingsController.scala +++ b/src/main/scala/app/SystemSettingsController.scala @@ -34,7 +34,7 @@ "baseDN" -> trim(label("Base DN", text(required))), "userNameAttribute" -> trim(label("User name attribute", text(required))), "mailAttribute" -> trim(label("Mail address attribute", text(required))), - "tls" -> trim(label("Enable StartTLS", optional(boolean()))), + "tls" -> trim(label("Enable TLS", optional(boolean()))), "keystore" -> trim(label("Keystore", optional(text()))) )(Ldap.apply)) )(SystemSettings.apply) diff --git a/src/main/scala/service/SystemSettingsService.scala b/src/main/scala/service/SystemSettingsService.scala index ba57533..85e94f7 100644 --- a/src/main/scala/service/SystemSettingsService.scala +++ b/src/main/scala/service/SystemSettingsService.scala @@ -116,7 +116,6 @@ val DefaultSmtpPort = 25 val DefaultLdapPort = 389 - val DefaultLdapKeystore = "/var/lib/gitbucket/keystore" private val AllowAccountRegistration = "allow_account_registration" private val Gravatar = "gravatar" diff --git a/src/main/scala/util/LDAPUtil.scala b/src/main/scala/util/LDAPUtil.scala index 3f0bad8..3f19b28 100644 --- a/src/main/scala/util/LDAPUtil.scala +++ b/src/main/scala/util/LDAPUtil.scala @@ -14,7 +14,7 @@ object LDAPUtil { private val LDAP_VERSION: Int = LDAPConnection.LDAP_V3 - private val logger = LoggerFactory.getLogger("LDAPUtil") + private val logger = LoggerFactory.getLogger(getClass().getName()) /** * Try authentication by LDAP using given configuration. @@ -27,7 +27,7 @@ ldapSettings.bindDN.getOrElse(""), ldapSettings.bindPassword.getOrElse(""), ldapSettings.tls.getOrElse(false), - ldapSettings.keystore.getOrElse(SystemSettingsService.DefaultLdapKeystore) + ldapSettings.keystore.getOrElse("") ) match { case Some(conn) => { withConnection(conn) { conn => @@ -48,7 +48,7 @@ userDN, password, ldapSettings.tls.getOrElse(false), - ldapSettings.keystore.getOrElse(SystemSettingsService.DefaultLdapKeystore) + ldapSettings.keystore.getOrElse("") ) match { case Some(conn) => { withConnection(conn) { conn => @@ -67,9 +67,11 @@ // Dynamically set Sun as the security provider Security.addProvider(new com.sun.net.ssl.internal.ssl.Provider()) - // Dynamically set the property that JSSE uses to identify - // the keystore that holds trusted root certificates - System.setProperty("javax.net.ssl.trustStore", keystore); + if (keystore.compareTo("") != 0) { + // Dynamically set the property that JSSE uses to identify + // the keystore that holds trusted root certificates + System.setProperty("javax.net.ssl.trustStore", keystore) + } } val conn: LDAPConnection = new LDAPConnection(new LDAPJSSEStartTLSFactory()) diff --git a/src/main/twirl/admin/system.scala.html b/src/main/twirl/admin/system.scala.html index 26c2087..9a02cb5 100644 --- a/src/main/twirl/admin/system.scala.html +++ b/src/main/twirl/admin/system.scala.html @@ -97,7 +97,7 @@