diff --git a/src/main/scala/gitbucket/core/view/helpers.scala b/src/main/scala/gitbucket/core/view/helpers.scala index b735e6f..d471c73 100644 --- a/src/main/scala/gitbucket/core/view/helpers.scala +++ b/src/main/scala/gitbucket/core/view/helpers.scala @@ -212,19 +212,19 @@ Html( message .replaceAll("\\[issue:([^\\s]+?)/([^\\s]+?)#((\\d+))\\]"){ m => - val issue = getIssueFromCache(m.group(1), m.group(2), m.group(3)) - if (issue.isDefined) { - s"""${m.group(1)}/${m.group(2)}#${m.group(3)}""" - } else { - s"${m.group(1)}/${m.group(2)}#${m.group(3)}" + getIssueFromCache(m.group(1), m.group(2), m.group(3)) match { + case Some(issue) => + s"""${m.group(1)}/${m.group(2)}#${m.group(3)}""" + case None => + s"${m.group(1)}/${m.group(2)}#${m.group(3)}" } } .replaceAll("\\[pullreq:([^\\s]+?)/([^\\s]+?)#((\\d+))\\]"){ m => - val pullreq = getIssueFromCache(m.group(1), m.group(2), m.group(3)) - if (pullreq.isDefined) { - s"""${m.group(1)}/${m.group(2)}#${m.group(3)}""" - } else { - s"${m.group(1)}/${m.group(2)}#${m.group(3)}" + getIssueFromCache(m.group(1), m.group(2), m.group(3)) match { + case Some(pullreq) => + s"""${m.group(1)}/${m.group(2)}#${m.group(3)}""" + case None => + s"${m.group(1)}/${m.group(2)}#${m.group(3)}" } } .replaceAll("\\[repo:([^\\s]+?)/([^\\s]+?)\\]") { m => diff --git a/src/main/twirl/gitbucket/core/helper/activities.scala.html b/src/main/twirl/gitbucket/core/helper/activities.scala.html index 26fdd70..e3eaa5d 100644 --- a/src/main/twirl/gitbucket/core/helper/activities.scala.html +++ b/src/main/twirl/gitbucket/core/helper/activities.scala.html @@ -24,57 +24,15 @@ case "create_tag" => simpleActivity(activity) case "delete_tag" => simpleActivity(activity) case "fork" => simpleActivity(activity) - case "push" => customActivity(activity){ -
- {activity.additionalInfo.get.split("\n").reverse.take(4).zipWithIndex.map{ case (commit, i) => - if(i == 3){ -
...
- } else { - if(commit.nonEmpty){ -
- {commit.substring(0, 7)} - {commit.substring(41)} -
- } - } - }} -
- } - case "create_wiki" => customActivity(activity){ -
- Created {activity.additionalInfo.get}. -
- } - case "edit_wiki" => customActivity(activity){ - activity.additionalInfo.get.split(":") match { - case Array(pageName, commitId) => -
- Edited {pageName}. - View the diff » -
- case Array(pageName) => -
- Edited {pageName}. -
- } - } - case "delete_wiki" => simpleActivity(activity) + case "push" => pushActivity(activity) + case "create_wiki" => createWikiActivity(activity) + case "edit_wiki" => editWikiActivity(activity) + case "delete_wiki" => simpleActivity(activity) }) } } -@customActivity(activity: gitbucket.core.model.Activity)(additionalInfo: Any) = { -
-
@gitbucket.core.helper.html.datetimeago(activity.activityDate)
-
- @helpers.avatarLink(activity.activityUserName, 16) - @helpers.activityMessage(activity.message) -
- @additionalInfo -
-} - @simpleActivity(activity: gitbucket.core.model.Activity) = {
@gitbucket.core.helper.html.datetimeago(activity.activityDate) @@ -85,3 +43,66 @@
} +@pushActivity(activity: gitbucket.core.model.Activity) = { +
+
@gitbucket.core.helper.html.datetimeago(activity.activityDate)
+
+ @helpers.avatarLink(activity.activityUserName, 16) + @helpers.activityMessage(activity.message) +
+
+ @activity.additionalInfo.get.split("\n").reverse.take(4).zipWithIndex.map { case (commit, i) => + @if(i == 3){ +
...
+ } else { + @if(commit.nonEmpty){ +
+ @{commit.substring(0, 7)} + @{commit.substring(41)} +
+ } + } + } +
+
+} + +@createWikiActivity(activity: gitbucket.core.model.Activity) = { +
+
@gitbucket.core.helper.html.datetimeago(activity.activityDate)
+
+ @helpers.avatarLink(activity.activityUserName, 16) + @helpers.activityMessage(activity.message) +
+
+ Created @{activity.additionalInfo}. +
+
+} + +@editWikiActivity(activity: gitbucket.core.model.Activity) = { +
+
@gitbucket.core.helper.html.datetimeago(activity.activityDate)
+
+ @helpers.avatarLink(activity.activityUserName, 16) + @helpers.activityMessage(activity.message) +
+ @defining(activity.additionalInfo.get.split(":")){ additionalInfo => + @if(additionalInfo.length == 2) { + @defining((additionalInfo(0), additionalInfo(1))) { case (pageName, commitId) => +
+ Edited @pageName. + View the diff » +
+ } + } + @if(additionalInfo.length == 1) { + @defining(additionalInfo(0)) { pageName => +
+ Edited @pageName. +
+ } + } + } +
+}