diff --git a/src/main/scala/gitbucket/core/view/helpers.scala b/src/main/scala/gitbucket/core/view/helpers.scala index 221b750..6284248 100644 --- a/src/main/scala/gitbucket/core/view/helpers.scala +++ b/src/main/scala/gitbucket/core/view/helpers.scala @@ -5,7 +5,7 @@ import gitbucket.core.controller.Context import gitbucket.core.model.CommitState -import gitbucket.core.plugin.{RenderRequest, PluginRegistry, Renderer} +import gitbucket.core.plugin.{RenderRequest, PluginRegistry} import gitbucket.core.service.{RepositoryService, RequestCache} import gitbucket.core.util.{FileUtil, JGitUtil, StringUtil} diff --git a/src/main/twirl/gitbucket/core/helper/checkicon.scala.html b/src/main/twirl/gitbucket/core/helper/checkicon.scala.html index 32a0c5a..b9726a7 100644 --- a/src/main/twirl/gitbucket/core/helper/checkicon.scala.html +++ b/src/main/twirl/gitbucket/core/helper/checkicon.scala.html @@ -1,6 +1,6 @@ @(condition: => Boolean) @if(condition){ - + } else { - + } \ No newline at end of file diff --git a/src/main/twirl/gitbucket/core/pulls/compare.scala.html b/src/main/twirl/gitbucket/core/pulls/compare.scala.html index bf00b94..2b728fd 100644 --- a/src/main/twirl/gitbucket/core/pulls/compare.scala.html +++ b/src/main/twirl/gitbucket/core/pulls/compare.scala.html @@ -139,7 +139,7 @@ } @if(hasWritePermission){ - function checkConflict(from, to, noConflictHandler, hasConflictHandler){ + function checkConflict(from, to){ $('.check-conflict').show(); $.get('@url(repository)/compare/' + from + '...' + to + '/mergecheck', function(data){ $('.check-conflict').html(data); }); diff --git a/src/main/twirl/gitbucket/core/repo/branches.scala.html b/src/main/twirl/gitbucket/core/repo/branches.scala.html index 40d353c..7b4eded 100644 --- a/src/main/twirl/gitbucket/core/repo/branches.scala.html +++ b/src/main/twirl/gitbucket/core/repo/branches.scala.html @@ -30,9 +30,17 @@ } }.getOrElse{ @if(context.loginAccount.isDefined){ - New Pull Request + New Pull Request }else{ - Compare + Compare } } @if(hasWritePermission){ diff --git a/src/test/scala/gitbucket/core/view/HelpersSpec.scala b/src/test/scala/gitbucket/core/view/HelpersSpec.scala new file mode 100644 index 0000000..b323393 --- /dev/null +++ b/src/test/scala/gitbucket/core/view/HelpersSpec.scala @@ -0,0 +1,51 @@ +package gitbucket.core.view + +import org.specs2.mutable._ +import gitbucket.core.model.Repository +import java.util.Date + +class HelpersSpec extends Specification { + def repository(defaultBranch: String, parentUserName: Option[String]) = + Repository( + userName = "some-user", + repositoryName = "some-repo", + isPrivate = false, + description = None, + defaultBranch = defaultBranch, + parentUserName = parentUserName, + parentRepositoryName = Some("some-repo"), + registeredDate = new Date(), + updatedDate = new Date(), + lastActivityDate = new Date(), + originUserName = Some("some-other-user"), + originRepositoryName = Some("some-repo") + ) + + "repositoryDefaultCompareOrigin" should { + "return default branch when not fork" in { + val repo = repository("master", None) + + helpers.repositoryDefaultCompareOrigin(repo) mustEqual "master" + } + + "return [upstream]:[branch] when a fork" in { + val repo = repository("some-branch", Some("parent-user")) + + helpers.repositoryDefaultCompareOrigin(repo) mustEqual "parent-user:some-branch" + } + } + + "encodeCompareBranch" should { + "not uri encode /" in { + helpers.encodeCompareBranch("foo/bar#baz") mustEqual "foo/bar%23baz" + } + + "not uri encode :" in { + helpers.encodeCompareBranch("foo:bar#baz") mustEqual "foo:bar%23baz" + } + + "uri encode special characters" in { + helpers.encodeCompareBranch("!#$&'()+,;=?@[]") mustEqual "%21%23%24%26%27%28%29%2B%2C%3B%3D%3F%40%5B%5D" + } + } +}