diff --git a/src/main/scala/gitbucket/core/controller/PullRequestsController.scala b/src/main/scala/gitbucket/core/controller/PullRequestsController.scala index f06e4d5..784844d 100644 --- a/src/main/scala/gitbucket/core/controller/PullRequestsController.scala +++ b/src/main/scala/gitbucket/core/controller/PullRequestsController.scala @@ -242,25 +242,21 @@ branchIsOutOfDate = JGitUtil.getShaByRef(repository.owner, repository.name, pullreq.branch) != Some( pullreq.commitIdFrom ), - needStatusCheck = context.loginAccount - .map { u => - branchProtection.needStatusCheck(u.userName) - } - .getOrElse(true), + needStatusCheck = context.loginAccount.forall { u => + branchProtection.needStatusCheck(u.userName) + }, hasUpdatePermission = hasDeveloperRole( pullreq.requestUserName, pullreq.requestRepositoryName, context.loginAccount ) && - context.loginAccount - .map { u => - !getProtectedBranchInfo( - pullreq.requestUserName, - pullreq.requestRepositoryName, - pullreq.requestBranch - ).needStatusCheck(u.userName) - } - .getOrElse(false), + context.loginAccount.exists { u => + !getProtectedBranchInfo( + pullreq.requestUserName, + pullreq.requestRepositoryName, + pullreq.requestBranch + ).needStatusCheck(u.userName) + }, hasMergePermission = hasMergePermission, commitIdTo = pullreq.commitIdTo ) diff --git a/src/main/scala/gitbucket/core/controller/SystemSettingsController.scala b/src/main/scala/gitbucket/core/controller/SystemSettingsController.scala index 6663d2f..d82bb2d 100644 --- a/src/main/scala/gitbucket/core/controller/SystemSettingsController.scala +++ b/src/main/scala/gitbucket/core/controller/SystemSettingsController.scala @@ -361,8 +361,8 @@ }) get("/admin/users")(adminOnly { - val includeRemoved = params.get("includeRemoved").map(_.toBoolean).getOrElse(false) - val includeGroups = params.get("includeGroups").map(_.toBoolean).getOrElse(false) + val includeRemoved = params.get("includeRemoved").exists(_.toBoolean) + val includeGroups = params.get("includeGroups").exists(_.toBoolean) val users = getAllUsers(includeRemoved, includeGroups) val members = users.collect { case account if (account.isGroupAccount) => diff --git a/src/main/scala/gitbucket/core/service/ActivityService.scala b/src/main/scala/gitbucket/core/service/ActivityService.scala index eec6c8e..0508b9d 100644 --- a/src/main/scala/gitbucket/core/service/ActivityService.scala +++ b/src/main/scala/gitbucket/core/service/ActivityService.scala @@ -39,9 +39,7 @@ if (isPublic == false) { list += activity } else { - if (!getRepositoryInfoFromCache(activity.userName, activity.repositoryName) - .map(_.isPrivate) - .getOrElse(true)) { + if (!getRepositoryInfoFromCache(activity.userName, activity.repositoryName).forall(_.isPrivate)) { list += activity } } @@ -61,9 +59,7 @@ var json: String = null while (list.length < 50 && { json = reader.readLine(); json } != null) { val activity = read[Activity](json) - if (!getRepositoryInfoFromCache(activity.userName, activity.repositoryName) - .map(_.isPrivate) - .getOrElse(true)) { + if (!getRepositoryInfoFromCache(activity.userName, activity.repositoryName).forall(_.isPrivate)) { list += activity } } @@ -83,9 +79,7 @@ val activity = read[Activity](json) if (owners.contains(activity.userName)) { list += activity - } else if (!getRepositoryInfoFromCache(activity.userName, activity.repositoryName) - .map(_.isPrivate) - .getOrElse(true)) { + } else if (!getRepositoryInfoFromCache(activity.userName, activity.repositoryName).forall(_.isPrivate)) { list += activity } } diff --git a/src/main/scala/gitbucket/core/service/RepositoryCreationService.scala b/src/main/scala/gitbucket/core/service/RepositoryCreationService.scala index 85b79c7..5d553c8 100644 --- a/src/main/scala/gitbucket/core/service/RepositoryCreationService.scala +++ b/src/main/scala/gitbucket/core/service/RepositoryCreationService.scala @@ -25,7 +25,7 @@ private val Creating = new ConcurrentHashMap[String, Option[String]]() def isCreating(owner: String, repository: String): Boolean = { - Option(Creating.get(s"${owner}/${repository}")).map(_.isEmpty).getOrElse(false) + Option(Creating.get(s"${owner}/${repository}")).exists(_.isEmpty) } def startCreation(owner: String, repository: String): Unit = { diff --git a/src/main/scala/gitbucket/core/service/WikiService.scala b/src/main/scala/gitbucket/core/service/WikiService.scala index 3f6d848..5cd4306 100644 --- a/src/main/scala/gitbucket/core/service/WikiService.scala +++ b/src/main/scala/gitbucket/core/service/WikiService.scala @@ -255,8 +255,7 @@ created = false updated = JGitUtil .getContentFromId(git, tree.getEntryObjectId, true) - .map(new String(_, "UTF-8") != content) - .getOrElse(false) + .exists(new String(_, "UTF-8") != content) } } } diff --git a/src/main/scala/gitbucket/core/ssh/GitCommand.scala b/src/main/scala/gitbucket/core/ssh/GitCommand.scala index a1596ca..233942e 100644 --- a/src/main/scala/gitbucket/core/ssh/GitCommand.scala +++ b/src/main/scala/gitbucket/core/ssh/GitCommand.scala @@ -144,11 +144,9 @@ override protected def runTask(authType: AuthType): Unit = { val execute = Database() withSession { implicit session => - getRepository(owner, repoName.replaceFirst("\\.wiki\\Z", "")) - .map { repositoryInfo => - !repositoryInfo.repository.isPrivate || isReadableUser(authType, repositoryInfo) - } - .getOrElse(false) + getRepository(owner, repoName.replaceFirst("\\.wiki\\Z", "")).exists { repositoryInfo => + !repositoryInfo.repository.isPrivate || isReadableUser(authType, repositoryInfo) + } } if (execute) { @@ -169,11 +167,9 @@ override protected def runTask(authType: AuthType): Unit = { val execute = Database() withSession { implicit session => - getRepository(owner, repoName.replaceFirst("\\.wiki\\Z", "")) - .map { repositoryInfo => - isWritableUser(authType, repositoryInfo) - } - .getOrElse(false) + getRepository(owner, repoName.replaceFirst("\\.wiki\\Z", "")).exists { repositoryInfo => + isWritableUser(authType, repositoryInfo) + } } if (execute) { diff --git a/src/main/scala/gitbucket/core/util/StringUtil.scala b/src/main/scala/gitbucket/core/util/StringUtil.scala index 40e9a7d..4a11b56 100644 --- a/src/main/scala/gitbucket/core/util/StringUtil.scala +++ b/src/main/scala/gitbucket/core/util/StringUtil.scala @@ -184,8 +184,7 @@ def removeUserName(baseUrl: String): String = baseUrl.replaceFirst("(https?://).+@", "$1") gitRepositoryUrl match { - case GitBucketUrlPattern(base, user, repository) - if baseUrl.map(removeUserName(base).startsWith).getOrElse(false) => + case GitBucketUrlPattern(base, user, repository) if baseUrl.exists(removeUserName(base).startsWith) => s"${removeUserName(base)}/$user/$repository" case GitHubUrlPattern(_, user, repository) => s"https://github.com/$user/$repository" case BitBucketUrlPattern(_, user, repository) => s"https://bitbucket.org/$user/$repository"