diff --git a/src/main/scala/gitbucket/core/controller/PullRequestsController.scala b/src/main/scala/gitbucket/core/controller/PullRequestsController.scala index 2f913c5..e43168c 100644 --- a/src/main/scala/gitbucket/core/controller/PullRequestsController.scala +++ b/src/main/scala/gitbucket/core/controller/PullRequestsController.scala @@ -50,7 +50,8 @@ )(PullRequestForm.apply) val mergeForm = mapping( - "message" -> trim(label("Message", text(required))) + "message" -> trim(label("Message", text(required))), + "strategy" -> trim(label("Strategy", text(required))) )(MergeForm.apply) case class PullRequestForm( @@ -69,7 +70,7 @@ labelNames: Option[String] ) - case class MergeForm(message: String) + case class MergeForm(message: String, strategy: String) get("/:owner/:repository/pulls")(referrersOnly { repository => val q = request.getParameter("q") @@ -259,6 +260,7 @@ recordMergeActivity(owner, name, loginAccount.userName, issueId, form.message) // merge git repository + // TODO Implement merge strategy! mergePullRequest(git, pullreq.branch, issueId, s"Merge pull request #${issueId} from ${pullreq.requestUserName}/${pullreq.requestBranch}\n\n" + form.message, new PersonIdent(loginAccount.fullName, loginAccount.mailAddress)) diff --git a/src/main/twirl/gitbucket/core/pulls/mergeguide.scala.html b/src/main/twirl/gitbucket/core/pulls/mergeguide.scala.html index 1eb4c22..472ffc5 100644 --- a/src/main/twirl/gitbucket/core/pulls/mergeguide.scala.html +++ b/src/main/twirl/gitbucket/core/pulls/mergeguide.scala.html @@ -139,8 +139,34 @@
- - +
+ + +
+
+ + + +
@@ -194,5 +220,10 @@ $('#merge-command-copy-1').attr('data-clipboard-text', $('#merge-command').text()); }); } + + $('.merge-strategy').click(function(){ + $('button#merge-strategy-btn > span.strong').text($(this).find('strong').text()); + $('hidden[name=strategy]').val($(this).data('value')); + }); });