diff --git a/src/main/scala/gitbucket/core/service/ProtectedBranchService.scala b/src/main/scala/gitbucket/core/service/ProtectedBranchService.scala index ecbcd19..a4ab4c3 100644 --- a/src/main/scala/gitbucket/core/service/ProtectedBranchService.scala +++ b/src/main/scala/gitbucket/core/service/ProtectedBranchService.scala @@ -71,7 +71,7 @@ pusher: String, mergePullRequest: Boolean )(implicit session: Session): Option[String] = { - if (mergePullRequest == true) { + if (mergePullRequest) { None } else { checkBranchProtection(owner, repository, receivePack, command, pusher) diff --git a/src/main/scala/gitbucket/core/util/Authenticator.scala b/src/main/scala/gitbucket/core/util/Authenticator.scala index b9c6020..5805022 100644 --- a/src/main/scala/gitbucket/core/util/Authenticator.scala +++ b/src/main/scala/gitbucket/core/util/Authenticator.scala @@ -38,7 +38,7 @@ case Some(x) if (repository.owner == x.userName) => action(repository) // TODO Repository management is allowed for only group managers? case Some(x) if (getGroupMembers(repository.owner).exists { m => - m.userName == x.userName && m.isManager == true + m.userName == x.userName && m.isManager }) => action(repository) case Some(x) if (getCollaboratorUserNames(userName, repoName, Seq(Role.ADMIN)).contains(x.userName)) => diff --git a/src/main/scala/gitbucket/core/util/Mailer.scala b/src/main/scala/gitbucket/core/util/Mailer.scala index 91d063a..78c31e2 100644 --- a/src/main/scala/gitbucket/core/util/Mailer.scala +++ b/src/main/scala/gitbucket/core/util/Mailer.scala @@ -41,7 +41,7 @@ htmlMsg: Option[String] = None, loginAccount: Option[Account] = None ): Option[HtmlEmail] = { - if (settings.notification == true) { + if (settings.notification) { settings.smtp.map { smtp => val email = new HtmlEmail email.setHostName(smtp.host) @@ -51,7 +51,7 @@ } smtp.ssl.foreach { ssl => email.setSSLOnConnect(ssl) - if (ssl == true) { + if (ssl) { email.setSslSmtpPort(smtp.port.get.toString) } } diff --git a/src/main/scala/gitbucket/core/view/helpers.scala b/src/main/scala/gitbucket/core/view/helpers.scala index ebfefeb..b735e6f 100644 --- a/src/main/scala/gitbucket/core/view/helpers.scala +++ b/src/main/scala/gitbucket/core/view/helpers.scala @@ -336,7 +336,7 @@ )(implicit context: Context): Html = { val avatarHtml = avatar(userName, size, tooltip, mailAddress) - val contentHtml = if (label == true) Html(avatarHtml.body + " " + userName) else avatarHtml + val contentHtml = if (label) Html(avatarHtml.body + " " + userName) else avatarHtml userWithContent(userName, mailAddress)(contentHtml) } @@ -446,14 +446,14 @@ } result.append(c) } - case '>' if tag == true => { + case '>' if tag => { tag = false result.append(c) } case _ if tag == false => { text.append(c) } - case _ if tag == true => { + case _ if tag => { result.append(c) } }