Merge remote-tracking branch 'upstream/stable' into merge_stable

update version to v1.36.0-rc.1

Build the tests and binary with -cov on POSIX ...

The CI was sending empty coverage reports because nothing
was being generated, as the variable was always false.
In the process, a bit of dead code was removed.

CI: Move single checks to Github, remove dead code ...

Remove support for very old frontend - we were not testing it anyways.
Move the useful checks to another job so they run once.

Remove internal mentions to Travis

Trivial: Fix #2774 - Color codes on windows terminal

Re-add CodeCov support

Trivial: Clean up temporary variable in Dub.fetch ...

And improve the message displayed to users.

Do not allow for removal of subpackages ...

Because it can mess up the system quite dramatically.

Improve unittest framework to have a virtual FS ...

This gets the unittest framework closer to the actual behavior,
and allows us to mock basic FS operations such as mkdir and writeFile.
Further improvements can be made to support more operations,
and to have package setup done before `TestDub` instantiation.

Adapt PackageManager.get[Best]Package to PackageName API ...

This paves the way to be able to automatically return subpackages.

Adapt loadSCMPackage to PackageName API

Trivial: Add 'in' on a parameter

Remove PackageName alias this to toString ...

The alias this was originally added to make the transition
less painful, however due to an overload resolution bug,
it makes it harder at the moment, as thje compiler prefers
calling the deprecated `string` overloads over the
`in PackageName` ones. So remove it and a few hacks along
the way.

Adapt dub.recipe.json to PackageName API

Adapt dub.recipe.sdl to PackageName API

Adapt PackageSuppliers to PackageName API ...

Since we recently did a semi-breaking change to PackageSuppliers,
now is the time to do it again (they will be in the same release).
Again the same logic applies: it's only a breaking change for those
inheriting from PackageSupplier, not those calling it,
and there is likely not a lot of people doing either out there.

Trivial: Adapt fixPathDependency to PackageName API

Trivial: Align PackageManager's lookup signatures

Trivial: Pass a PackageName to loadSCMPackage

Deprecate Package.getInternalSubPackage, simplify DepedencyResolver ...

The PackageManager will always eagerly load subpackages,
whether they are path based or embedded (see addPackages).
So calling getInternalSubPackage if getSubPackage returned
null will never yield a non-Nullable object.
In short, we can simplify that code greatly, and as
Package.getInternalSubPackage does not handle all use
case and require using the PackageManager anyway, just
deprecate it and direct people to the right function.

Improve Dub.fetch API ...

The API was not ideal, as it meant the caller has
to be a bit repetitive in what it was doing:
- defaultPlacementLocation should be used when possible;
- A library user would most likely want FetchOptions.none;
- The most simple use case would be 'dub.fetch(pkgName)',
  meaning get me the latest version of pkgName, as is used
  by the tools fetching code;
All of this is now supported, in addition to a transition
to using the PackageName API.

Adapt SelectedVersions to PackageName API ...

Adapting to the PackageName API meant relaxing the input
a SelectedVersion method can accept, as we now handle
the subpackage part gracefully (ignoring it), instead
of potentially running into issue.

Let uesr $DFLAGS override build settings as much as possible ...

Signed-off-by: Andrei Horodniceanu <a.horodniceanu@proton.me>

packagesuppliers/filesystem.d: Only look for versions of package_id ...

When looking for versions of a package don't include any files that
aren't versions of the queried package.

If a directory contains the files botan-1.zip and botan-math-2.zip
the current implementation would report both 1 and math-2 as
candidates followed by an error that math-2 is not a valid version.

Signed-off-by: Andrei Horodniceanu <a.horodniceanu@proton.me>

Simplify DependencyResolver.getRawPackage ...

Remove an extra variable and use early returns.

Adapt getPackagePath to PackageName API ...

Now that we have the PackageName type, we need to
go through API and decide what the string means.
Multiple places expect a main package, and only
some expect a subpackage. Starting from the bottom,
it is impossible to call getPackagePath with
a subpackage, as the package path of that subpackage
depends on the main package. However, we want to be
lax here, so always return the main package path.

Expand selections file handling to handle new versions ...

Up until now, the selections file has had a `fileVersion` in it,
but that number was always stuck to 1.
In order to make it possible to handle more than one version,
a bit of scaffolding needs to happen in the config parser.
This lays the ground for a version 2 of the selections file.

Simplify PackageManager.getPackagePath ...

All callers ended up appending to the returned path,
so just do it in getPackagePath and save ourself some trouble.

Trivial: Make PackageManager.addPackages protected ...

So that it can be reused in the TestPackageManager.