Fix package scanning order. ...

Packages registered using add-path need to come before cached packages.

Avoid throw expression - fixes compilation on LDC 1.30.0.

PackMan: Provide an overload of storeFetchedPackage that doesn't expose Location ...

This way we keep the internals of PackageManager within the PackageManager,
instead of having external classes be aware of the paths we use.

fix coloring for dub upgrade -s

PackageManager: Only iterate on internal fromPath array, not everything ...

getOrLoadPackage is only used for path-based dependencies,
which are only stored in m_internal.fromPath.
We can thus reduce the iteration by only using fromPath.
If someone had a path-based dependency that pointed to a version-based package,
it would lead to this package being loaded twice, but that's not really a concern,
as it would not lead to problem either.

Remove PlacementLocation information from Dub.fetch ...

Let it rely solely on the PackageManager instead.

PackMan: Deprecate overload leaking location path ...

Currently, a lot of the internals of the PackageManager are leaking.
The getPackage overload accepting both a version and a NativePath
is an example of such a leak, and looking at the usage sites
show that things can be simplified by taking a PlacementLocation,
which is a higher level representation of the path.

Move PackageManager.getPackagePath to Location ...

It is more suited as a Location method, as it returns a path based on PackagePath.
This also allows us to reduce the leak of information about Location
happening in dub.

Deprecate PackageManager.completeSearchPath ...

It is no longer used within the PackageManager and leaks quite a bit of the internals,
instead users should have functionalities exposed via the PackageManager's API.

Dub: Do not re-load already loaded tool Package ...

Instead of giving the path to the Package we just loaded,
just give it the Package we just loaded.

Deprecate an unused PackageManager.getPackage ovrld ...

This overload is not used anywhere in `dub`, and its use case is not clear.
Path where packages are stored should ideally be only known to `PackageManager`,
and the API should expose `PlacementLocation` instead of bare `NativePath`.
With this in mind, this overload doesn't fit the picture.

Dub: Remove redundant variable m_projectPath

Deprecate PackageManager.getFirstPackage ...

This function returns the 'first' package, which is very arbitrary.
Instead, always return the highest matching package for stable results.

PackageManager: Simplify removeLocalPackage by using algorithm ...

Instead of doing (potentially) multiple append operations of two slices,
just do a filter + array which is much easier to read and prove correct.

PackageManager: Remove m_disableDefaultSearchPath, use array instead ...

The boolean is redundant, as the array will always be null / empty
if it's true, and have 3 entries otherwise.

Trivial: Improve PackageManager.m_repositories documentation

Merge pull request #2468 from MartinNowak/merge_stable ...

merge stable

Signed-off-by: Iain Buclaw <ibuclaw@users.noreply.github.com>
Merged-on-behalf-of: Iain Buclaw <ibuclaw@users.noreply.github.com>

Merge remote-tracking branch 'upstream/stable' into merge_stable

Remove PackageManager deprecations from v1.20.0 ...

Those deprecations have been introduced in v1.20.0,
so if we follow the same 10 releases policy as DMD,
we are good to have them removed in the next release.
Deprecated in 48a26db

PackageManager: Make internal scope have the priority, remove m_temporaryPackages ...

Before, `m_internal.fromPath` was unused, and `m_internal.localPackages` was only
used for the bare mode search paths, while a similar array of packages named
`m_temporaryPackages` was used for `Repository` / `NativePath` dependencies.

In both cases, this array should have priority over the other scopes,
so we can just remove the duplication and swap the iteration order.

update version to v1.29.2

Merge pull request #2466 from Geod24/style ...

Minor: Align dub.recipe.selection style with dub.recipe.packagerecipe

Signed-off-by: Nicholas Wilson <thewilsonator@users.noreply.github.com>
Merged-on-behalf-of: Nicholas Wilson <thewilsonator@users.noreply.github.com>

PackageManager: Move the scanning logic to Location, segment per Location ...

Before this change, all packages were surprisingly stored in m_internal.localPackages,
which itself is a new addition to replace an array of 'Package'.
This means that even though we had an architecture that looks like it segmented
things per repository / location, it actually didn't,
and things worked solely based on the order packages were added it
(and the fact we did a linear search).

PackageManager.Location: Split packages registered locally and read from path ...

A Location, having a default search path (the package path),
and some extra search path, optionally, previously stored
all of them in the same array. However, this creates problems,
as we want to move to lazy load the packages in the default
search path, while we can't lazy load packages in non-default ones.

Minor: Align dub.recipe.selection style with dub.recipe.packagerecipe ...

During review of the PR that switched PackageRecipe parsing to use Configy,
WebFreak pointed out that having an internal, private structure used for
parsing YAML field was preferable to having it at module level.
This aligns the names and the approach used with the one in PackageRecipe.

Trivial: Fix typo in documentation

Trivial: Fix some style issues

PackageManager: Simplify logic around refreshing packages ...

Passing an empty array will lead to the same behavior
as using a boolean, so we can remove the parameter.

Trivial: Rename refresh_existing_packages parameter to refresh

Dub: Use UpgradeOptions.dryRun instead of printUpgradesOnly ...

The latter is said to be deprecated, and this is the only usage.