Deprecate an unused PackageManager.getPackage ovrld

Fork: 0

johnpearcey / dub_jkp

Browse code Deprecate an unused PackageManager.getPackage ovrld This overload is not used anywhere in `dub`, and its use case is not clear. Path where packages are stored should ideally be only known to `PackageManager`, and the API should expose `PlacementLocation` instead of bare `NativePath`. With this in mind, this overload doesn't fit the picture. master
1 parent ac8f524 commit e29a366324d1f92c1d9298247625769eaca14679 Geod24 authored on 12 Sep 2022 Mathias LANG committed on 13 Sep 2022

Browse code

This overload is not used anywhere in `dub`, and its use case is not clear.
Path where packages are stored should ideally be only known to `PackageManager`,
and the API should expose `PlacementLocation` instead of bare `NativePath`.
With this in mind, this overload doesn't fit the picture.

master

1 parent ac8f524 commit e29a366324d1f92c1d9298247625769eaca14679

Geod24 authored on 12 Sep 2022

Mathias LANG committed on 13 Sep 2022

Patch

Unified Split

Showing 1 changed file

                Ignore Space
               Show notes
              View
            
          
          1 ■■■■■
          source/dub/packagemanager.d
 		return getPackage(name, Version(ver), path);
	}
 
	/// ditto
	deprecated("Use another `PackageManager` API, open an issue if none suits you")
	Package getPackage(string name, NativePath path)
	{
		foreach( p; getPackageIterator(name) )
			if (p.path.startsWith(path))
 		return getPackage(name, Version(ver), path);
 	}
 	/// ditto
+	deprecated("Use another `PackageManager` API, open an issue if none suits you")
 	Package getPackage(string name, NativePath path)
 	{
 		foreach( p; getPackageIterator(name) )
 			if (p.path.startsWith(path))

Show line notes below